Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MangaUpGlobal : use API & protobuff #914

Merged
merged 3 commits into from
Dec 9, 2024
Merged

MangaUpGlobal : use API & protobuff #914

merged 3 commits into from
Dec 9, 2024

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented Dec 3, 2024 •
edited
Loading

Closes #913

@erictbar
Copy link

erictbar commented Dec 3, 2024

Free chapters now work. 👍

Unlocked chapters still getting the same error, while logged in in HaruNeko.

The chapter is not available (not purchased/unlocked/public)!
Exception
    at default.FetchPages (http://localhost:3000/src/engine/websites/MangaUpGlobal.ts:41:33)
    at async Chapter.Update (http://localhost:3000/src/engine/providers/MediaPlugin.ts:72:28)
    at async DownloadTask.Run (http://localhost:3000/src/engine/DownloadTask.ts:49:7)
    at async DownloadManager.Process (http://localhost:3000/src/engine/DownloadManager.ts:63:11)

Let me know if you need help testing.

@MikeZeDev
Copy link
Contributor Author

has paid chapters worked before tho?

@erictbar
Copy link

erictbar commented Dec 3, 2024

Paid chapters have not been accessible in the web app before, it was added recently:
https://global-api.manga-up.com/webrelease/?secret=3b50f5791fa643963a3163dd751b67f01678556f48f68c80954e581053016400&os_ver=0&app_ver=0

ronny1982
ronny1982 approved these changes Dec 8, 2024
View reviewed changes
web/src/engine/websites/MangaUpGlobal.proto Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.proto Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
web/src/engine/websites/MangaUpGlobal.ts Outdated Show resolved Hide resolved
@MikeZeDev
Copy link
Contributor Author

Paid chapters will be considered but not right now, we are busy 👍

@MikeZeDev MikeZeDev merged commit 3e989d5 into master Dec 9, 2024
6 checks passed
@MikeZeDev MikeZeDev deleted the mangaup branch December 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronny1982 ronny1982 ronny1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MangaUp (Global): cant get images
3 participants
@MikeZeDev @erictbar @ronny1982